Attention is currently required from: msuraev.

Patch set 1:Code-Review +1

View Change

1 comment:

• File src/osmo_ss7_hmrt.c:

  • Patch Set #1, Line 232: LOGP(DLSS7, LOGL_ERROR, "The AS %s is down\n", as->cfg.name);

    I think the log line could benefit from some context like "canout route" or "cannot send packet" or whatever. For a debug message like above/below, I think it's fine. but for an error message intended for the "casual" user, I think it's best to be more descriptive about why we're logging the message "AS is down" right now.

To view, visit change 31295. To unsubscribe, or for help writing mail filters, visit settings.