Attention is currently required from: daniel, pespin.

fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-abis/+/38927?usp=email )

Change subject: ipaccess: Convert BTS OML & RSL link to use stream_cli ......................................................................

Patch Set 1: Code-Review+1

(6 comments)

File src/input/ipaccess.c:

https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/7df669a7_82556089?... : PS1, Line 494: OSMO_ASSERT(cli); Why are you so assert()ive? ;)

`ipaccess_bts_e1i_ts_stream_cli()` does assert() `cli` is not `NULL`. Either this one or the one inside `ipaccess_bts_e1i_ts_stream_cli()` is redundant.

https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/a3508b43_e02a7d98?... : PS1, Line 545: osmo_stream_cli_send Why not returning `rc` of this function?

https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/49fd0510_bb6c10d3?... : PS1, Line 928: *msgb_put(nmsg2, 1) = IPAC_MSGT_ID_ACK; `msgb_v_put(nmsg2, IPAC_MSGT_ID_ACK)`

https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/f8adf616_5ab18d59?... : PS1, Line 944: uint8_t *data = msgb_l2(msg); `const`?

https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/b6751ff9_415a8f80?... : PS1, Line 992: err: : return -1; `goto`s can be replaced with `return -1`?

https://gerrit.osmocom.org/c/libosmo-abis/+/38927/comment/a56686ff_a3988cdd?... : PS1, Line 1014: e1i_ts->line `s/e1i_ts->line/line/`