Attention is currently required from: daniel, pespin.

Patch set 1:Code-Review +1

View Change

6 comments:

• File src/input/ipaccess.c:

  • Patch Set #1, Line 494: OSMO_ASSERT(cli);

    Why are you so assert()ive? ;)

    `ipaccess_bts_e1i_ts_stream_cli()` does assert() `cli` is not `NULL`.
    Either this one or the one inside `ipaccess_bts_e1i_ts_stream_cli()` is redundant.

  • Patch Set #1, Line 545: osmo_stream_cli_send

    Why not returning `rc` of this function?

  • Patch Set #1, Line 928: *msgb_put(nmsg2, 1) = IPAC_MSGT_ID_ACK;

    `msgb_v_put(nmsg2, IPAC_MSGT_ID_ACK)`

  • Patch Set #1, Line 944: uint8_t *data = msgb_l2(msg);

    `const`?

  • Patch Set #1, Line 992:

    err:
    	return -1;
    

    `goto`s can be replaced with `return -1`?

  • Patch Set #1, Line 1014: e1i_ts->line

    `s/e1i_ts->line/line/`

To view, visit change 38927. To unsubscribe, or for help writing mail filters, visit settings.