Attention is currently required from: pespin.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504?usp=email )

Change subject: HTTP_Adapter: allow API users to specifiy custom header ......................................................................

Patch Set 2:

(4 comments)

File library/HTTP_Adapter.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/a703254b_c50d7... PS1, Line 41: function ts_HTTP_Header(template charstring body := omit,

I'd prefer having this one prefixed "f_ts_", since it's actually a function. […]

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/c033169a_48c0c... PS1, Line 42: template charstring host := omit,

template (omit) charstring

Done

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/2752abad_bcf73... PS1, Line 55: if (ispresent(body)) {

I'm not sure ispresent() can be used this way, or only for optional fields in a record. […]

I have verified that it works with ispresent(), but if (not istemplatekind(body, "omit")) also works.

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36504/comment/05a2da73_5e253... PS1, Line 59: /* Add custom header lines, already existing headers (name) are updated */

I think it makes sense to move this to a separate function "merge_headers()" or "overlay_headers()". […]

Done