Attention is currently required from: pespin.

View Change

4 comments:

• File library/HTTP_Adapter.ttcn:

  • Patch Set #1, Line 41: function ts_HTTP_Header(template charstring body := omit,

    I'd prefer having this one prefixed "f_ts_", since it's actually a function. […]

    Done

  • Patch Set #1, Line 42: template charstring host := omit,

    template (omit) charstring

    Done

  • Patch Set #1, Line 55: if (ispresent(body)) {

    I'm not sure ispresent() can be used this way, or only for optional fields in a record. […]

    I have verified that it works with ispresent(), but if (not istemplatekind(body, "omit")) also works.

  • Patch Set #1, Line 59: /* Add custom header lines, already existing headers (name) are updated */

    I think it makes sense to move this to a separate function "merge_headers()" or "overlay_headers()". […]

    Done

To view, visit change 36504. To unsubscribe, or for help writing mail filters, visit settings.