Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113?usp=email )

Change subject: s1ap_proxy: handle_ies(): pass IEI path to handle_ie() ......................................................................

Patch Set 1:

(2 comments)

File src/s1ap_proxy.erl:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113/comment/799b51ca_03912... : PS1, Line 122: path = []}}.

btw iirc you can set the default values for a type when you declare it (line 71)

Yes, this can be done. But I think it's also fine having the initial state fully and explicitly initialized (fields that are not `undefined`) here in one place.

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39113/comment/549849a8_82290... : PS1, Line 395: when P :: [s1ap_ie_id()], %% Path

why not simply renaming the params instead of adding comments? lol

I am fine with renaming the actual params (will update this patch), but only for the `-spec`. For the actual functions below I prefer using short, single letter variable names because we're dealing with rather long ASN.1 identifiers and nested records.