Attention is currently required from: pespin.

View Change

2 comments:

• File src/s1ap_proxy.erl:

  • Patch Set #1, Line 122: path = []}}.

    btw iirc you can set the default values for a type when you declare it (line 71)

    Yes, this can be done. But I think it's also fine having the initial state fully and explicitly initialized (fields that are not `undefined`) here in one place.

  • Patch Set #1, Line 395: when P :: [s1ap_ie_id()], %% Path

    why not simply renaming the params instead of adding comments? lol

    I am fine with renaming the actual params (will update this patch), but only for the `-spec`. For the actual functions below I prefer using short, single letter variable names because we're dealing with rather long ASN.1 identifiers and nested records.

To view, visit change 39113. To unsubscribe, or for help writing mail filters, visit settings.