Attention is currently required from: fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/30812 )

Change subject: layer23/sysinfo: implement decoding of SI13 Rest Octets ......................................................................

Patch Set 4:

(1 comment)

File src/host/layer23/include/osmocom/bb/common/sysinfo.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/30812/comment/a295f2b8_991af10d PS2, Line 74: uint8_t supported;

Yes, but <stdbool.h> in not used this file.

Add a line #include <stdbool.h> :)

The existing fields are using uint8_t for boolean logic.

Yes, which is confusing to the user/reader of the code, since it's not clear what those hold (I was not sure what the uint8_t si* fields contains until I looked deeply in the code).

So I'd better stay consistent. This is not critical, right?

I'd favour using bool wherever possible, makes everyone's life easier to understand how to fill/read the structs rather than having to look to existing code which integer values are expected.