Attention is currently required from: fixeria.

View Change

1 comment:

• File src/host/layer23/include/osmocom/bb/common/sysinfo.h:

  • Patch Set #2, Line 74: uint8_t supported;

    Yes, but <stdbool.h> in not used this file.

    Add a line #include <stdbool.h> :)

    The existing fields are using uint8_t for boolean logic.
    Yes, which is confusing to the user/reader of the code, since it's not clear what those hold (I was not sure what the uint8_t si* fields contains until I looked deeply in the code).

    So I'd better stay consistent. This is not critical, right?

    I'd favour using bool wherever possible, makes everyone's life easier to understand how to fill/read the structs rather than having to look to existing code which integer values are expected.

To view, visit change 30812. To unsubscribe, or for help writing mail filters, visit settings.