Attention is currently required from: pespin.

fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38309?usp=email )

Change subject: s1gw: use the new counter name (out_pkt.forward.unmodified) ......................................................................

Patch Set 1:

(1 comment)

File s1gw/S1GW_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38309/comment/5cb048d4_f9eb5... : PS1, Line 206: {name := mp_statsd_prefix & "ctr.s1ap.proxy.out_pkt.forward.unmodified.value", mtype := "c", min := 2, max := 2}

this change of name looks weird to me tbh. […]

I changed it because it looked more logical to have it together with other `out_pkt` counters. We're taking decision on the incoming PDUs -- this is right, but the counter tells that the outgoing PDU was basically an incoming PDU without modifications. Does that make sense? I could move it back to `in_pkt`, but then `S1GW_CTR_S1AP_PROXY_IN_PKT_REPLY_ERAB_SETUP_RSP` looks confusing as if the input packet was a reply. Alternatively, we could remove the IN/OUT classification?