Attention is currently required from: pespin.

View Change

1 comment:

• File s1gw/S1GW_Tests.ttcn:

  • Patch Set #1, Line 206: {name := mp_statsd_prefix & "ctr.s1ap.proxy.out_pkt.forward.unmodified.value", mtype := "c", min := 2, max := 2}

    this change of name looks weird to me tbh. […]

    I changed it because it looked more logical to have it together with other `out_pkt` counters. We're taking decision on the incoming PDUs -- this is right, but the counter tells that the outgoing PDU was basically an incoming PDU without modifications. Does that make sense? I could move it back to `in_pkt`, but then `S1GW_CTR_S1AP_PROXY_IN_PKT_REPLY_ERAB_SETUP_RSP` looks confusing as if the input packet was a reply. Alternatively, we could remove the IN/OUT classification?

To view, visit change 38309. To unsubscribe, or for help writing mail filters, visit settings.