Attention is currently required from: pespin. falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email ) Change subject: bring twrtp into libosmo-netif ...................................................................... Patch Set 5: (3 comments) File src/twrtp_base.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/5f5204b2_f73fd53… : PS1, Line 120: * file descriptor passing mechanism - hence twrtp layer must have a public Can this point be marked as resolved? https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/ed8266be_331a960… : PS1, Line 132: * another variant of this API with that alternative behavior. Still not sure about 3G and IuUP specifically, but more generally speaking, if some application of RTP says "don't use RTCP", they still typically require or at least expect an even UDP port number for RTP, and the corresponding odd port is still reserved for what would have been RTCP. The way to handle such scenarios with twrtp is to let twrtp library bind to both UDP ports, let it swallow all packets that arrive on the odd-numbered port, and let it parse them as if they were RTCP. But don't send out any outgoing RTCP packets (which the library won't do on its own until and unless the application requests RTCP output and configures SDES), and simply ignore the existence of the built-in RTCP receiver and parser. Section 5.6 of the manual says basically the same thing. Can this point be marked as resolved? File src/twrtp_traffic.c: https://gerrit.osmocom.org/c/libosmo-netif/+/39281/comment/eb625540_bb7a79d… : PS2, Line 32: struct osmo_twrtp *endp = osmo_iofd_get_data(iofd); Can this point be marked as resolved? -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/39281?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ib63215aaf13ef8ab8f2e0c8d310164cd5c8824eb Gerrit-Change-Number: 39281 Gerrit-PatchSet: 5 Gerrit-Owner: falconia <falcon(a)freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pespin(a)sysmocom.de> Gerrit-Attention: pespin <pespin(a)sysmocom.de> Gerrit-Comment-Date: Mon, 18 Aug 2025 05:38:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: falconia <falcon(a)freecalypso.org> Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>