Attention is currently required from: pespin.

View Change

3 comments:

• File src/twrtp_base.c:

  • Patch Set #1, Line 120: * file descriptor passing mechanism - hence twrtp layer must have a public

    New ThemWi CN sw components, starting with `tw-border-mgw`, already depend on the full `libosmo*` su […]

    Can this point be marked as resolved?

  • Patch Set #1, Line 132: * another variant of this API with that alternative behavior.

    I really know next to nothing about 3G. […]

    Still not sure about 3G and IuUP specifically, but more generally speaking, if some application of RTP says "don't use RTCP", they still typically require or at least expect an even UDP port number for RTP, and the corresponding odd port is still reserved for what would have been RTCP. The way to handle such scenarios with twrtp is to let twrtp library bind to both UDP ports, let it swallow all packets that arrive on the odd-numbered port, and let it parse them as if they were RTCP. But don't send out any outgoing RTCP packets (which the library won't do on its own until and unless the application requests RTCP output and configures SDES), and simply ignore the existence of the built-in RTCP receiver and parser. Section 5.6 of the manual says basically the same thing.

    Can this point be marked as resolved?

• File src/twrtp_traffic.c:

  • Patch Set #2, Line 32: struct osmo_twrtp *endp = osmo_iofd_get_data(iofd);

    Acknowledged

    Can this point be marked as resolved?

To view, visit change 39281. To unsubscribe, or for help writing mail filters, visit settings.