Attention is currently required from: dexter, laforge.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35452?usp=email )

Change subject: Implement convoluted encoding of UCS-2 as per TS 102 221 Annex A ......................................................................

Patch Set 5: Code-Review+1

(2 comments)

File pySim/construct.py:

https://gerrit.osmocom.org/c/pysim/+/35452/comment/7ce5eab6_82f821af PS5, Line 79: ch.to_bytes(1, byteorder='big'), Not critical, but for just one byte I would rather do `bytes([ch])`. Same below.

https://gerrit.osmocom.org/c/pysim/+/35452/comment/2af102cf_a5d24ce2 PS5, Line 81: elif obj[0] == 0x82: We may want to raise an exception if `obj[0]` is neither `0x81` nor `0x82`, rather than returning `None`?