Attention is currently required from: dexter, laforge.

Patch set 5:Code-Review +1

View Change

2 comments:

• File pySim/construct.py:

  • Patch Set #5, Line 79: ch.to_bytes(1, byteorder='big'),

    Not critical, but for just one byte I would rather do `bytes([ch])`. Same below.

  • Patch Set #5, Line 81: elif obj[0] == 0x82:

    We may want to raise an exception if `obj[0]` is neither `0x81` nor `0x82`, rather than returning `None`?

To view, visit change 35452. To unsubscribe, or for help writing mail filters, visit settings.