Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email ) Change subject: gsm_utils: add gprs_tlli2tmsi() ...................................................................... Patch Set 1: (12 comments) File src/gsm/gsm_utils.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/b7229cba_0228cc07?… : PS1, Line 1029: uint32_t ptmsi = (1 << 31) | (1 << 30); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/9e658a45_82673990?… : PS1, Line 1031: switch (gprs_tlli_type(tlli)) { please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/96eccdf9_ba0eb744?… : PS1, Line 1032: case TLLI_LOCAL: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/5843f7c8_b23cca48?… : PS1, Line 1033: case TLLI_FOREIGN: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/71e9e9bf_a9c38e8b?… : PS1, Line 1034: break; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/717ca6a2_e7fe2bb8?… : PS1, Line 1034: break; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/fbaf20b1_c001f60f?… : PS1, Line 1036: return 0xffffffff; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/32009601_1cd58a59?… : PS1, Line 1036: return 0xffffffff; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/6333cc3c_a1618fa1?… : PS1, Line 1037: } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/97cb0019_be73c6ff?… : PS1, Line 1039: ptmsi |= tlli; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/a05572ea_41ab60d7?… : PS1, Line 1040: return ptmsi; please, no spaces at the start of a line File tests/gprs/gprs_test.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890): https://gerrit.osmocom.org/c/libosmocore/+/38764/comment/ec3800c3_b577f92f?… : PS1, Line 113: static void test_ptmsi_tlli() Bad function definition - void test_ptmsi_tlli() should probably be void test_ptmsi_tlli(void) -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/38764?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I9d3464922c89383099a5f3cdd1458c0ecc28ee18 Gerrit-Change-Number: 38764 Gerrit-PatchSet: 1 Gerrit-Owner: lynxis lazus &lt;lynxis(a)fe80.eu&gt; Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Wed, 13 Nov 2024 19:17:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No