View Change

12 comments:

• File src/gsm/gsm_utils.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 1029: uint32_t ptmsi = (1 << 31) | (1 << 30);

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 1031: switch (gprs_tlli_type(tlli)) {

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 1032: case TLLI_LOCAL:

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 1033: case TLLI_FOREIGN:

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 1034: break;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 1034: break;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 1036: return 0xffffffff;

    code indent should use tabs where possible

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 1036: return 0xffffffff;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 1037: }

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 1039: ptmsi |= tlli;

    please, no spaces at the start of a line

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 1040: return ptmsi;

    please, no spaces at the start of a line

• File tests/gprs/gprs_test.c:

  • Robot Comment from checkpatch (run ID jenkins-gerrit-lint-19890):

    Patch Set #1, Line 113: static void test_ptmsi_tlli()

    Bad function definition - void test_ptmsi_tlli() should probably be void test_ptmsi_tlli(void)

To view, visit change 38764. To unsubscribe, or for help writing mail filters, visit settings.