Attention is currently required from: dexter, fixeria, neels. laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email ) Change subject: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi ...................................................................... Patch Set 7: Code-Review+1 (2 comments) File pySim/esim/saip/personalization.py: https://gerrit.osmocom.org/c/pysim/+/39742/comment/77dfcdc5_a3eee2d7?usp=em… : PS7, Line 67: = shouldn't that be a double-equals (also below)? to me it looks like an assignment rather than a comparison? https://gerrit.osmocom.org/c/pysim/+/39742/comment/a0f0005a_ad7564bd?usp=em… : PS7, Line 100: allow_types = (str, int, ) Does the comma with empty element imply that None is a vaid input value? In that case, I'd prefer an explicit None. Not critical. Just saying I don't understand the way that code is written. -- To view, visit https://gerrit.osmocom.org/c/pysim/+/39742?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I6522be4c463e34897ca9bff2309b3706a88b3ce8 Gerrit-Change-Number: 39742 Gerrit-PatchSet: 7 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: laforge <laforge(a)osmocom.org> Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: dexter <pmaier(a)sysmocom.de> Gerrit-Comment-Date: Sat, 19 Apr 2025 16:11:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes