Attention is currently required from: dexter, fixeria, neels.

laforge has posted comments on this change by neels. ( https://gerrit.osmocom.org/c/pysim/+/39742?usp=email )

Change subject: [2/6] personalization: refactor ConfigurableParameter, Iccid, Imsi ......................................................................

Patch Set 7: Code-Review+1

(2 comments)

File pySim/esim/saip/personalization.py:

https://gerrit.osmocom.org/c/pysim/+/39742/comment/77dfcdc5_a3eee2d7?usp=ema... : PS7, Line 67: = shouldn't that be a double-equals (also below)? to me it looks like an assignment rather than a comparison?

https://gerrit.osmocom.org/c/pysim/+/39742/comment/a0f0005a_ad7564bd?usp=ema... : PS7, Line 100: allow_types = (str, int, ) Does the comma with empty element imply that None is a vaid input value? In that case, I'd prefer an explicit None. Not critical. Just saying I don't understand the way that code is written.