Attention is currently required from: dexter, fixeria, neels.

Patch set 7:Code-Review +1

View Change

2 comments:

• File pySim/esim/saip/personalization.py:

  • Patch Set #7, Line 67: =

    shouldn't that be a double-equals (also below)? to me it looks like an assignment rather than a comparison?

  • Patch Set #7, Line 100: allow_types = (str, int, )

    Does the comma with empty element imply that None is a vaid input value? In that case, I'd prefer an explicit None. Not critical. Just saying I don't understand the way that code is written.

To view, visit change 39742. To unsubscribe, or for help writing mail filters, visit settings.