Attention is currently required from: fixeria, pespin.

osmith has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmocore/+/40295?usp=email )

Change subject: Introduce tests/osmo-config-merge testsuite ......................................................................

Patch Set 4:

(6 comments)

File tests/osmo-config-merge/Makefile.am:

https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/6944e778_68ec345b?u... : PS4, Line 25: } >'$(srcdir)/package.m4' What do we need package.m4 for?

https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/09c8c254_20aeb22f?u... : PS4, Line 46: [ -e /proc/cpuinfo ] && cat /proc/cpuinfo This is already done in tests/Makefile.am, so I would remove it here.

https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/c5a9850a_f208585d?u... : PS4, Line 47: $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS) ```suggestion $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ```

https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/d1a71072_698b27d1?u... : PS4, Line 51: $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS) ```suggestion $(TESTSUITEFLAGS) ```

File tests/osmo-config-merge/atlocal.in:

PS4: do we need this empty file?

File tests/osmo-config-merge/testA.ok:

https://gerrit.osmocom.org/c/libosmocore/+/40295/comment/f755bf44_dfefc29a?u... : PS4, Line 74: power-ramp step-size 8000 mdB : power-ramp step-interval 1 : phy 0 instance 0 : power-ramp step-size 2000 mdB is this correct? I would have expected that the new power-ramp step-size overwrites the previous one