Attention is currently required from: fixeria, pespin.

View Change

6 comments:

• File tests/osmo-config-merge/Makefile.am:

  • Patch Set #4, Line 25: } >'$(srcdir)/package.m4'

    What do we need package.m4 for?

  • Patch Set #4, Line 46: [ -e /proc/cpuinfo ] && cat /proc/cpuinfo

    This is already done in tests/Makefile.am, so I would remove it here.

  • Patch Set #4, Line 47: $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)

    ```suggestion
    	$(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS)
    ```

  • Patch Set #4, Line 51: $(TESTSUITEFLAGS) ENABLE_URING=$(ENABLE_URING) ENABLE_URING_TESTS=$(ENABLE_URING_TESTS)

    ```suggestion
    		$(TESTSUITEFLAGS)
    ```

• File tests/osmo-config-merge/atlocal.in:

  • Patch Set #4:

    do we need this empty file?

• File tests/osmo-config-merge/testA.ok:

  • Patch Set #4, Line 74:

      power-ramp step-size 8000 mdB
      power-ramp step-interval 1
      phy 0 instance 0
      power-ramp step-size 2000 mdB
    

    is this correct? I would have expected that the new power-ramp step-size overwrites the previous one

To view, visit change 40295. To unsubscribe, or for help writing mail filters, visit settings.