Attention is currently required from: fixeria.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34298?usp=email )

Change subject: oml: ipacc: send GPRS Cell attributes based on IPA Object Version ......................................................................

Patch Set 3: Code-Review+1

(1 comment)

File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34298/comment/9e3c29c1_064de6bb PS3, Line 262: if (is_osmobts(bts) || cell->mo.ipaccess.obj_version >= 4) { I'd prefer having an explicit check for nanobts here, even if it may actually not be needed: "||(is_nanobts(bts) && cell->mo.ipaccess.obj_version >= 4)"

It is easier for users to understand what this obj_version check is about (nanobts).