Attention is currently required from: fixeria.

Patch set 3:Code-Review +1

View Change

1 comment:

• File src/osmo-bsc/bts_ipaccess_nanobts_omlattr.c:

  • Patch Set #3, Line 262: if (is_osmobts(bts) || cell->mo.ipaccess.obj_version >= 4) {

    I'd prefer having an explicit check for nanobts here, even if it may actually not be needed:
     "||(is_nanobts(bts) && cell->mo.ipaccess.obj_version >= 4)"
     
    It is easier for users to understand what this obj_version check is about (nanobts).

To view, visit change 34298. To unsubscribe, or for help writing mail filters, visit settings.