Attention is currently required from: arehbein.
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31878?usp=email )
Change subject: Make RLC timing data configurable ......................................................................
Patch Set 2:
(2 comments)
File src/osmo-bsc/net_init.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/0b3ff55e_64a5f16d PS2, Line 51: { .T = 3142, .default_val = 20,
So, how do I know which timers are BTS-specific or depend on BTS support?
Easy procedure: Would it make sense for a user/operator to set different values per BTS? Answer: yes! => per bts.
Wuthout looking in detail, some of thse values clearly could be tunned different on different BTS, with different operation constrains, different volume of users, different load, etc.
I think to have one group named "bts" should be enough, even if some bts don't support setting some of the params.
File tests/nanobts_omlattr/nanobts_omlattr_test.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/31878/comment/4931c325_0debbf22 PS2, Line 228: 0x02, 0x00, 0x02, 0xa3, 0x00, 0x09,
No default values have been changed. […]
ah ok. Can you at least take the chance to align them to the same column?
-
pespin