Attention is currently required from: arehbein.

View Change

2 comments:

• File src/osmo-bsc/net_init.c:

  • Patch Set #2, Line 51: { .T = 3142, .default_val = 20,

    So, how do I know which timers are BTS-specific or depend on BTS support?

    Easy procedure: Would it make sense for a user/operator to set different values per BTS? Answer: yes! => per bts.

    Wuthout looking in detail, some of thse values clearly could be tunned different on different BTS, with different operation constrains, different volume of users, different load, etc.

    I think to have one group named "bts" should be enough, even if some bts don't support setting some of the params.

• File tests/nanobts_omlattr/nanobts_omlattr_test.c:

  • Patch Set #2, Line 228: 0x02, 0x00, 0x02, 0xa3, 0x00, 0x09,

    No default values have been changed. […]

    ah ok. Can you at least take the chance to align them to the same column?

To view, visit change 31878. To unsubscribe, or for help writing mail filters, visit settings.