Attention is currently required from: osmith, fixeria.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/32399 )

Change subject: Move out of alloc_algo code modifying the data model ......................................................................

Patch Set 8:

(3 comments)

File src/alloc_algo.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/da659a14_c29af8ff PS8, Line 761: memset(res->usf, -1, sizeof(res->usf));

Are you sure this is correct? `sizeof(res->usf)` is not 8 in this case, but `sizeof(int) * 8`. […]

Done

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/32dc6a6b_b47ed6d9 PS8, Line 800: res->usf

`&res->usf[0]` would be cleaner here, otherwise it looks like you're passing a USF value, but then y […]

Done

https://gerrit.osmocom.org/c/osmo-pcu/+/32399/comment/fa563ca1_06abbfb9 PS8, Line 863: struct alloc_resources_res *res)

coemstic: alignment

Done