Attention is currently required from: osmith, fixeria.

View Change

3 comments:

• File src/alloc_algo.cpp:

  • Patch Set #8, Line 761: memset(res->usf, -1, sizeof(res->usf));

    Are you sure this is correct? `sizeof(res->usf)` is not 8 in this case, but `sizeof(int) * 8`. […]

    Done

  • Patch Set #8, Line 800: res->usf

    `&res->usf[0]` would be cleaner here, otherwise it looks like you're passing a USF value, but then y […]

    Done

  • Patch Set #8, Line 863: struct alloc_resources_res *res)

    coemstic: alignment

    Done

To view, visit change 32399. To unsubscribe, or for help writing mail filters, visit settings.