Attention is currently required from: fixeria, laforge, pespin.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34899?usp=email )

Change subject: client: collapse codecs[] and ptmap[]; allow codec variants ......................................................................

Patch Set 11:

(3 comments)

This change is ready for review.

File include/osmocom/mgcp_client/mgcp_client.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/34899/comment/dda640dc_a61a6d04 PS10, Line 82: int ptmap_cmp(const struct ptmap *a, const struct ptmap *b);

yes, it is const ... […]

Done

File include/osmocom/mgcp_client/mgcp_client_fsm.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/34899/comment/cc913811_dab6ce00 PS10, Line 33: enum mgcp_codecs codecs[MGCP_MAX_CODECS];

IIRC you can mark fields with the OSMO_DEPRECATED flag, this way it shows up in gcc when used by any […]

Done

File src/libosmo-mgcp-client/mgcp_client_fsm.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/34899/comment/8731a67a_b2b77bd4 PS10, Line 700: struct osmo_fsm_inst *mgcp_conn_create(struct mgcp_client *mgcp, struct osmo_fsm_inst *parent_fi,

I would remove it from the .h, make it a static function. […]

Done