Attention is currently required from: fixeria, laforge, pespin.

View Change

3 comments:

• File include/osmocom/mgcp_client/mgcp_client.h:

  • Patch Set #10, Line 82: int ptmap_cmp(const struct ptmap *a, const struct ptmap *b);

    yes, it is const ... […]

    Done

• File include/osmocom/mgcp_client/mgcp_client_fsm.h:

  • Patch Set #10, Line 33: enum mgcp_codecs codecs[MGCP_MAX_CODECS];

    IIRC you can mark fields with the OSMO_DEPRECATED flag, this way it shows up in gcc when used by any […]

    Done

• File src/libosmo-mgcp-client/mgcp_client_fsm.c:

  • Patch Set #10, Line 700: struct osmo_fsm_inst *mgcp_conn_create(struct mgcp_client *mgcp, struct osmo_fsm_inst *parent_fi,

    I would remove it from the .h, make it a static function. […]

    Done

To view, visit change 34899. To unsubscribe, or for help writing mail filters, visit settings.