Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260 )

Change subject: bsc_nat_fsm: initial conn-oriented forwarding ......................................................................

Patch Set 3: Code-Review+1

(2 comments)

File src/osmo-bsc-nat/bsc_nat_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/f5425a25_7a431792 PS3, Line 74: static int sccp_sap_get_peer_addr_in(struct bsc_nat_ss7_inst *src, struct osmo_sccp_addr **peer_addr_in, I think both *called_addr and *calling_addr arguments can be marked 'const'?

https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27260/comment/bbbc9acb_df5934bb PS3, Line 78: *peer_addr_in = called_addr; ... you would need to cast pointers here and below, but I think it's fine.