Attention is currently required from: osmith.

Patch set 3:Code-Review +1

View Change

2 comments:

• File src/osmo-bsc-nat/bsc_nat_fsm.c:

  • Patch Set #3, Line 74: static int sccp_sap_get_peer_addr_in(struct bsc_nat_ss7_inst *src, struct osmo_sccp_addr **peer_addr_in,

    I think both *called_addr and *calling_addr arguments can be marked 'const'?

  • Patch Set #3, Line 78: *peer_addr_in = called_addr;

    ... you would need to cast pointers here and below, but I think it's fine.

To view, visit change 27260. To unsubscribe, or for help writing mail filters, visit settings.