Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/30116 ) Change subject: [codecs filter] add codec_filter.h,c ...................................................................... Patch Set 1: Code-Review+1 (4 comments) File include/osmocom/msc/codec_filter.h: https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/f7d25854_c420e439 PS1, Line 49: /* Resulting choice of supported codecs, usually the intersection of the above, At first glance it looks a bit strange why you are mixing the RTP port here with the codec resolution. What's the rationale behind doing it here together? File src/libmsc/codec_filter.c: https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/d77199e8_7e9147e0 PS1, Line 8: * SPDX-License-Identifier: GPL-2.0+ no AGPL? https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/6e1cd713_de0f5efc PS1, Line 28: static void sdp_add_all_mobile_codecs(struct sdp_audio_codecs *ac) why is this called "mobile_codecs" but the one below is "utran_codecs"? Call this oen geran_codecs? https://gerrit.osmocom.org/c/osmo-msc/+/30116/comment/d55ca8e3_dc324698 PS1, Line 124: /* If osmo-msc were able to trigger a re-assignment after the remote side has picked a codec mismatching the Does this mean osmo-msc currently doesn't support it but it could support it? -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/30116 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I4d90f7ca62f2307a7b93dd164aeecbf4bd98ff0a Gerrit-Change-Number: 30116 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: neels <nhofmeyr(a)sysmocom.de> Gerrit-Comment-Date: Mon, 14 Nov 2022 10:39:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment