Attention is currently required from: neels.

Patch set 1:Code-Review +1

View Change

4 comments:

• File include/osmocom/msc/codec_filter.h:

  • Patch Set #1, Line 49: /* Resulting choice of supported codecs, usually the intersection of the above,

    At first glance it looks a bit strange why you are mixing the RTP port here with the codec resolution. What's the rationale behind doing it here together?

• File src/libmsc/codec_filter.c:

  • Patch Set #1, Line 8: * SPDX-License-Identifier: GPL-2.0+

    no AGPL?

  • Patch Set #1, Line 28: static void sdp_add_all_mobile_codecs(struct sdp_audio_codecs *ac)

    why is this called "mobile_codecs" but the one below is "utran_codecs"? Call this oen geran_codecs?

  • Patch Set #1, Line 124: /* If osmo-msc were able to trigger a re-assignment after the remote side has picked a codec mismatching the

    Does this mean osmo-msc currently doesn't support it but it could support it?

To view, visit change 30116. To unsubscribe, or for help writing mail filters, visit settings.