[S] Change in ...osmo-s1gw[master]: s1ap_proxy: fix per-eNB ?S1GW_CTR_S1AP_PROXY_IN_PKT_ALL - gerrit-log

17 Jul 2025


      Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40717?usp=email )
Change subject: s1ap_proxy: fix per-eNB ?S1GW_CTR_S1AP_PROXY_IN_PKT_ALL
......................................................................
Patch Set 1:
(1 comment)
File src/s1ap_proxy.erl:
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40717/comment/722246e2_030e1... :
PS1, Line 649:         _ ->
...
this "_" should actually be "undefined" afaiu?
Strictly speaking, yes. But the `_` also works in a situation when the eNB sends a different Global-eNB-ID in subsequent S1 Setup Request PDUs. I know it's unlikely to happen, but it does not bring additional complexity so why not.
-- 
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/40717?usp=email
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: If57f0c43f41d5f38759f9746a4f6299d3233a450
Gerrit-Change-Number: 40717
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria vyanitskiy@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin pespin@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 17 Jul 2025 17:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin pespin@sysmocom.de