Attention is currently required from: pespin.
View Change
1 comment:
File src/s1ap_proxy.erl:
Patch Set #1, Line 649: _ ->
this "_" should actually be "undefined" afaiu?
Strictly speaking, yes. But the `_` also works in a situation when the eNB sends a different Global-eNB-ID in subsequent S1 Setup Request PDUs. I know it's unlikely to happen, but it does not bring additional complexity so why not.
To view, visit change 40717. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: If57f0c43f41d5f38759f9746a4f6299d3233a450
Gerrit-Change-Number: 40717
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Thu, 17 Jul 2025 17:52:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>