Attention is currently required from: dexter, fixeria, osmith.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37456?usp=email )

Change subject: pySim-smpp2sim.py: Simulate SMSC+CN+RAN+UE for OTA testing ......................................................................

Patch Set 4:

(3 comments)

File pySim-smpp2sim.py:

https://gerrit.osmocom.org/c/pysim/+/37456/comment/0f3c0ac2_24de28bf PS3, Line 34: from pprint

no longer used?

Done

https://gerrit.osmocom.org/c/pysim/+/37456/comment/4d98bae2_0d031b15 PS3, Line 41: from zope.interface import implementer

curious: what package this belongs to?

I believe it's an upstraeam dependency of twisted. https://docs.twisted.org/en/twisted-17.5.0/core/howto/components.html

https://gerrit.osmocom.org/c/pysim/+/37456/comment/b51c83ef_1a7910bf PS3, Line 59: logger = logging.getLogger(__name__)

so you have a module local logger module (which is good), but still mostly using the root logger (`l […]

Done