Attention is currently required from: dexter, fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/37456?usp=email ) Change subject: pySim-smpp2sim.py: Simulate SMSC+CN+RAN+UE for OTA testing ...................................................................... Patch Set 4: (3 comments) File pySim-smpp2sim.py: https://gerrit.osmocom.org/c/pysim/+/37456/comment/0f3c0ac2_24de28bf PS3, Line 34: from pprint
no longer used? Done
https://gerrit.osmocom.org/c/pysim/+/37456/comment/4d98bae2_0d031b15 PS3, Line 41: from zope.interface import implementer
curious: what package this belongs to? I believe it's an upstraeam dependency of twisted. https://docs.twisted.org/en/twisted-17.5.0/core/howto/components.html
https://gerrit.osmocom.org/c/pysim/+/37456/comment/b51c83ef_1a7910bf PS3, Line 59: logger = logging.getLogger(__name__)
so you have a module local logger module (which is good), but still mostly using the root logger (`l […] Done
-- To view, visit https://gerrit.osmocom.org/c/pysim/+/37456?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie5bae9d823bca6f6c658bd455303f63bace2258c Gerrit-Change-Number: 37456 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-CC: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Sat, 13 Jul 2024 21:09:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment