Attention is currently required from: dexter, fixeria, osmith.

View Change

3 comments:

• File pySim-smpp2sim.py:

  • Patch Set #3, Line 34: from pprint

    no longer used?

    Done

  • Patch Set #3, Line 41: from zope.interface import implementer

    curious: what package this belongs to?

    I believe it's an upstraeam dependency of twisted. https://docs.twisted.org/en/twisted-17.5.0/core/howto/components.html

  • Patch Set #3, Line 59: logger = logging.getLogger(__name__)

    so you have a module local logger module (which is good), but still mostly using the root logger (`l […]

    Done

To view, visit change 37456. To unsubscribe, or for help writing mail filters, visit settings.