Attention is currently required from: lynxis lazus.

pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311?usp=email )

Change subject: Add VTY command to list TCAP ranges for an AS ......................................................................

Patch Set 8:

(5 comments)

File src/Makefile.am:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/913e2a1d_aa0a2b... : PS8, Line 13: ss7_as_loadshare_tcap_vty.h \ tcap_loadshare_vty.{c,h}?

This should also be inside a "if BUILD_WITH_TCAP_LOADSHARING" btw.

File src/ss7_as_loadshare_tcap_vty.h:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/fbc233d7_e8b625... : PS8, Line 6: #ifdef WITH_TCAP_LOADSHARING Drop this, simply only include the header when ifdef BUILD_WITH_TCAP_LOADSHARING

File src/ss7_as_loadshare_tcap_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/e542e0ed_17f627... : PS8, Line 50: "show cs7 instance <0-15> as tcap-ranges name AS_NAME", are we using the same ordering in other vty command? looks weird ot have "as", then "tcap-ranges" and finalyl the "name AS_NAME" referring to the "as" at the start...

"show cs7 instance <0-15> tcap-ranges as name AS_NAME" look a lot more ordered to me.

File src/ss7_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/8c03befd_06402e... : PS8, Line 42: #include "ss7_as_loadshare_tcap_vty.h" ifdef

https://gerrit.osmocom.org/c/libosmo-sigtran/+/41311/comment/eb2573d9_50e45f... : PS8, Line 1487: ss7_tcap_vty_init(); ifdef