Attention is currently required from: lynxis lazus.

View Change

5 comments:

• File src/Makefile.am:

  • Patch Set #8, Line 13: ss7_as_loadshare_tcap_vty.h \

    tcap_loadshare_vty.{c,h}?

    This should also be inside a "if BUILD_WITH_TCAP_LOADSHARING" btw.

• File src/ss7_as_loadshare_tcap_vty.h:

  • Patch Set #8, Line 6: #ifdef WITH_TCAP_LOADSHARING

    Drop this, simply only include the header when ifdef BUILD_WITH_TCAP_LOADSHARING

• File src/ss7_as_loadshare_tcap_vty.c:

  • Patch Set #8, Line 50: "show cs7 instance <0-15> as tcap-ranges name AS_NAME",

    are we using the same ordering in other vty command? looks weird ot have "as", then "tcap-ranges" and finalyl the "name AS_NAME" referring to the "as" at the start...

    "show cs7 instance <0-15> tcap-ranges as name AS_NAME" look a lot more ordered to me.

• File src/ss7_vty.c:

  • Patch Set #8, Line 42: #include "ss7_as_loadshare_tcap_vty.h"

    ifdef

  • Patch Set #8, Line 1487: ss7_tcap_vty_init();

    ifdef

To view, visit change 41311. To unsubscribe, or for help writing mail filters, visit settings.