Attention is currently required from: dexter, laforge, neels, pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/36361?usp=email )

Change subject: Change msgb ownership in processing of received msgb ......................................................................

Patch Set 2:

(4 comments)

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/054b7bba_98b3a44e PS2, Line 1191: return rc missing `msgb_free()`?

https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/2e47f083_0389a5bc PS2, Line 1205: return rc missing `msgb_free()`?

https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/949625fb_1bc94e6f PS2, Line 1212: return rc missing `msgb_free()`?

File src/libosmo-mgcp/mgcp_osmux.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/36361/comment/e31c09c9_cb3f3273 PS2, Line 217: return -1; missing `msgb_free()` here and below? AFAIU, if a function claims to take ownership, then it's also responsible for `free()`ing it in all error paths? If not, this should be clarified in the docs above.