Attention is currently required from: dexter, laforge, neels, pespin.

View Change

4 comments:

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #2, Line 1191: return rc

    missing `msgb_free()`?

  • Patch Set #2, Line 1205: return rc

    missing `msgb_free()`?

  • Patch Set #2, Line 1212: return rc

    missing `msgb_free()`?

• File src/libosmo-mgcp/mgcp_osmux.c:

  • Patch Set #2, Line 217: return -1;

    missing `msgb_free()` here and below? AFAIU, if a function claims to take ownership, then it's also responsible for `free()`ing it in all error paths? If not, this should be clarified in the docs above.

To view, visit change 36361. To unsubscribe, or for help writing mail filters, visit settings.