[M] Change in libosmocore[master]: socket: Introduce API osmo_sock_multiaddr_get_name_buf() - gerrit-log

4 Dec 2023

Attention is currently required from: neels, pespin.

laforge has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35180?usp=email )

Change subject: socket: Introduce API osmo_sock_multiaddr_get_name_buf()
......................................................................

Patch Set 2: Code-Review+1

(2 comments)

File src/core/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/35180/comment/69741a2f_dea5ba34 
PS1, Line 1993: v6 = !!s
...
  I only care about checking if the address is ipv6 in
the case where we only have 1 IP, because in th […] Done

https://gerrit.osmocom.org/c/libosmocore/+/35180/comment/3d4b51f2_63325c1c 
PS1, Line 2052: int osmo_sock_get_name_buf(char *str, size_t str_len, int fd)
...
  I prefer keeping the multiaddr prefix instead of a
"2", we already use it in several places. […] agreeing with separate api
and agreeing with multiaddr.

-- 
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35180?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I48950754ed6f61ee5ffa04a447fab8903f10acc0
Gerrit-Change-Number: 35180
Gerrit-PatchSet: 2
Gerrit-Owner: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge &lt;laforge(a)osmocom.org&gt;
Gerrit-CC: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Gerrit-Attention: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-Comment-Date: Mon, 04 Dec 2023 16:38:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels &lt;nhofmeyr(a)sysmocom.de&gt;
Comment-In-Reply-To: pespin &lt;pespin(a)sysmocom.de&gt;
Gerrit-MessageType: comment