Attention is currently required from: neels, pespin.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35180?usp=email )

Change subject: socket: Introduce API osmo_sock_multiaddr_get_name_buf() ......................................................................

Patch Set 2: Code-Review+1

(2 comments)

File src/core/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/35180/comment/69741a2f_dea5ba34 PS1, Line 1993: v6 = !!s

I only care about checking if the address is ipv6 in the case where we only have 1 IP, because in th […]

Done

https://gerrit.osmocom.org/c/libosmocore/+/35180/comment/3d4b51f2_63325c1c PS1, Line 2052: int osmo_sock_get_name_buf(char *str, size_t str_len, int fd)

I prefer keeping the multiaddr prefix instead of a "2", we already use it in several places. […]

agreeing with separate api and agreeing with multiaddr.