Attention is currently required from: neels, pespin.
Patch set 2:Code-Review +1
View Change
2 comments:
File src/core/socket.c:
Patch Set #1, Line 1993: v6 = !!s
I only care about checking if the address is ipv6 in the case where we only have 1 IP, because in th […]
Done
Patch Set #1, Line 2052: int osmo_sock_get_name_buf(char *str, size_t str_len, int fd)
I prefer keeping the multiaddr prefix instead of a "2", we already use it in several places. […]
agreeing with separate api and agreeing with multiaddr.
To view, visit change 35180. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I48950754ed6f61ee5ffa04a447fab8903f10acc0
Gerrit-Change-Number: 35180
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-CC: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: neels <nhofmeyr@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Mon, 04 Dec 2023 16:38:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de>
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment