Attention is currently required from: neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817 )
Change subject: add library/PFCP_*, deps/PFCP ......................................................................
Patch Set 3:
(3 comments)
File library/PFCP_CodecPort_CtrlFunct.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/76f2f4d3_d3956... PS1, Line 7: inout PFCP_PT portRef,
yes, i most definitely copied it, because i would not have had a clue how to structure a new kind of […]
Ack
File library/PFCP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/bfea1ff6_5ca44... PS1, Line 18: type enumerated e_PFCP_Cause {
was going to move now but noticed that PFCP_Types.ttcn is from deps/titan.ProtocolModules.PFCP_v15. […]
I thought it was in our library/ dir, then it's fine you can keep it in Templates.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/28817/comment/1c12fe40_6612d... PS1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP {
honestly i'd like to know. i don't see constrictions nor errors with these templates. […]
marking as (value) means you cannot pass a template containing a field which is not set to a value, aka ? or *, which means the compiler shouldn't allow you passing a tr_ template in there.
Similarly, (present) prevents people from passing omit to a function not expecting it. Furthermore, it clarifies to the reader what is expected to be passed there. This kinda "nullable" mark some languages have, which allows knowing whether passing a null pointer is accepted or not.
Having correct restrictions properly written also translate to work hours spent by all others.
-
pespin