Attention is currently required from: neels.

View Change

3 comments:

• File library/PFCP_CodecPort_CtrlFunct.ttcn:

  • Patch Set #1, Line 7: inout PFCP_PT portRef,

    yes, i most definitely copied it, because i would not have had a clue how to structure a new kind of […]

    Ack

• File library/PFCP_Templates.ttcn:

  • Patch Set #1, Line 18: type enumerated e_PFCP_Cause {

    was going to move now but noticed that PFCP_Types.ttcn is from deps/titan.ProtocolModules.PFCP_v15. […]

    I thought it was in our library/ dir, then it's fine you can keep it in Templates.

  • Patch Set #1, Line 418: function ts_PFCP_Session_Est_Req(charstring node_id, OCT8 cp_seid, Create_PDR_list create_pdr, Create_FAR_list create_far) return template PDU_PFCP {

    honestly i'd like to know. i don't see constrictions nor errors with these templates. […]

    marking as (value) means you cannot pass a template containing a field which is not set to a value, aka ? or *, which means the compiler shouldn't allow you passing a tr_ template in there.

    Similarly, (present) prevents people from passing omit to a function not expecting it. Furthermore, it clarifies to the reader what is expected to be passed there. This kinda "nullable" mark some languages have, which allows knowing whether passing a null pointer is accepted or not.

    Having correct restrictions properly written also translate to work hours spent by all others.

To view, visit change 28817. To unsubscribe, or for help writing mail filters, visit settings.