Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30610 )
Change subject: logging: rework the macros ......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Commit Message:
https://gerrit.osmocom.org/c/libosmocore/+/30610/comment/0156bff9_b11f202f PS1, Line 9: For some reason
I guess the idea was to avoid function calls?
What's even more important is that with macros we can do lazy format string evaluation:
https://people.osmocom.org/fixeria/logp_test.c
With a function the arguments (like osmo_hexdump() calls) will always be evaluated, regardless of the current logging level. So I vote against this patch.