Attention is currently required from: Hoernchen. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30610 ) Change subject: logging: rework the macros ...................................................................... Patch Set 1: Code-Review-2 (1 comment) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/30610/comment/0156bff9_b11f202f PS1, Line 9: For some reason What's even more important is that with macros we can do lazy format string evaluation: https://people.osmocom.org/fixeria/logp_test.c With a function the arguments (like osmo_hexdump() calls) will always be evaluated, regardless of the current logging level. So I vote against this patch. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30610 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I03efa954cb9e991d2c3da4b61b12aac651e0efa2 Gerrit-Change-Number: 30610 Gerrit-PatchSet: 1 Gerrit-Owner: Hoernchen <ewild(a)sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: Hoernchen <ewild(a)sysmocom.de> Gerrit-Comment-Date: Thu, 15 Dec 2022 02:10:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment