Attention is currently required from: Hoernchen.

Patch set 1:Code-Review -2

View Change

1 comment:

• Commit Message:

  • Patch Set #1, Line 9: For some reason

    I guess the idea was to avoid function calls?

    What's even more important is that with macros we can do lazy format string evaluation:

    https://people.osmocom.org/fixeria/logp_test.c

    With a function the arguments (like osmo_hexdump() calls) will always be evaluated, regardless of the current logging level. So I vote against this patch.

To view, visit change 30610. To unsubscribe, or for help writing mail filters, visit settings.