Attention is currently required from: fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33692 ) Change subject: pySim/cards: Add type annotations ...................................................................... Patch Set 4: (4 comments) File pySim/cards.py: https://gerrit.osmocom.org/c/pysim/+/33692/comment/80e2a8d3_a48aa915 PS4, Line 39: reset Done https://gerrit.osmocom.org/c/pysim/+/33692/comment/33ef514c_ab1c41cd PS4, Line 47: set_apdu_parameter thanks, didn't know that and I think never did that anywhere so far. https://gerrit.osmocom.org/c/pysim/+/33692/comment/3af71635_868c1cde PS4, Line 124: Hexstr Done https://gerrit.osmocom.org/c/pysim/+/33692/comment/8c539bb2_7e9e9481 PS4, Line 134: Hexstr Done -- To view, visit https://gerrit.osmocom.org/c/pysim/+/33692 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Id5752a64b59097584301c860ebf74d858ed3d240 Gerrit-Change-Number: 33692 Gerrit-PatchSet: 4 Gerrit-Owner: laforge <laforge(a)osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier(a)sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jul 2023 19:41:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-MessageType: comment