Attention is currently required from: fixeria.

View Change

4 comments:

• File pySim/cards.py:

  • Patch Set #4, Line 39: reset

    Missing return type annotation. Something like `-> Optional[... […]

    Done

  • Patch Set #4, Line 47: set_apdu_parameter

    Functions returning nothing should be annotated as such using `-> None`.

    thanks, didn't know that and I think never did that anywhere so far.

  • Patch Set #4, Line 124: Hexstr

    `-> Optional[Hexstr]`

    Done

  • Patch Set #4, Line 134: Hexstr

    `-> Optional[Hexstr]`

    Done

To view, visit change 33692. To unsubscribe, or for help writing mail filters, visit settings.